-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pasting from clipboard values support #774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wandroll
force-pushed
the
fixPastInputWithSpace
branch
2 times, most recently
from
March 7, 2024 16:17
c92ba18
to
7a33c36
Compare
wandroll
changed the title
Improve pasting from clipboard valeus support
Improve pasting from clipboard values support
Mar 7, 2024
wandroll
force-pushed
the
fixPastInputWithSpace
branch
from
March 7, 2024 16:29
7a33c36
to
778e30e
Compare
m-jovan
approved these changes
Mar 7, 2024
vscav
requested changes
Mar 7, 2024
test-app/tests/integration/components/amount-input/component-test.ts
Outdated
Show resolved
Hide resolved
test-app/tests/integration/components/amount-input/component-test.ts
Outdated
Show resolved
Hide resolved
wandroll
force-pushed
the
fixPastInputWithSpace
branch
from
March 8, 2024 07:42
778e30e
to
7d5cd55
Compare
Do you think we could remove the empty scope from the commit names? Like: - test(): add a way to simulate paste event
+ test: add a way to simulate paste event
- feat(): handle pasted strings
+ feat: handle pasted strings |
wandroll
force-pushed
the
fixPastInputWithSpace
branch
from
March 8, 2024 08:45
7d5cd55
to
11ae13b
Compare
vscav
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wandroll 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims at fixing this issue described here : #773
by providing better support for paste from clipboard: